DO NOT MERGE - PROD tracking - Beta v4.0 prod branch #2427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amkCha
changed the title
Signed-off-by: Fabio Di Fabio <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: F Bojarski <[email protected]>
amkCha
force-pushed
the
beta-v4.0-rc13-branch
branch
from
a9d6409 to
20fc4a2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
amkCha
changed the title
* For PRAGUE, the blockchain ref tests source changes : the tests are generated from ethereum/execution-spec-tests repo. We download the tar from the releases to get the already available "fixtures" (json files). * This PR adds 3 new gradle tasks downloadExecutionSpecFixtures download tar file in build folder generateExecutionSpecBlockchainTests untar and generate the BlockchainReferenceTest referenceExecutionSpecBlockchainTests launches the tests * BlockchainReferenceTestTools class and template have been made generic to handle both sources for ref tests ethereum/tests repo, our current submodule ethereum/execution-spec-tests repo, from which we download a tar
Signed-off-by: F Bojarski <[email protected]>
amkCha
force-pushed
the
beta-v4.0-rc13-branch
branch
from
cc23ac3 to
e4ff372
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
amkCha
force-pushed
the
beta-v4.0-rc13-branch
branch
from
0cca787 to
288b24a
Compare
…acer into beta-v4.0-rc13-branch
Signed-off-by: F Bojarski <[email protected]>
Signed-off-by: F Bojarski <[email protected]>
Signed-off-by: F Bojarski <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
* For PRAGUE, the blockchain ref tests source changes : the tests are generated from ethereum/execution-spec-tests repo. We download the tar from the releases to get the already available "fixtures" (json files). * This PR adds 3 new gradle tasks downloadExecutionSpecFixtures download tar file in build folder generateExecutionSpecBlockchainTests untar and generate the BlockchainReferenceTest referenceExecutionSpecBlockchainTests launches the tests * BlockchainReferenceTestTools class and template have been made generic to handle both sources for ref tests ethereum/tests repo, our current submodule ethereum/execution-spec-tests repo, from which we download a tar
This updates the release version to rc18 which includes only the gas calculation fix for TX skip sections.
amkCha
force-pushed
the
beta-v4.0-rc13-branch
branch
from
071c4ac to
b90b701
Compare
…hash() This may help fix @ameziane's performance issue. Note: this deviates from the spec which identifies empty code using a comparison to KECCAK(()) It should be functionally equivalent.
OlivierBBB
force-pushed
the
beta-v4.0-rc13-branch
branch
2 times, most recently
from
7e7278a to
e9fcf70
Compare
Signed-off-by: Fabio Di Fabio <[email protected]>
| } | ||
|
|
||
| @Override | ||
| public void traceTransaction(Trace.Txndata trace) {} |
There was a problem hiding this comment.
Bug: Redundant trace override causes confusion in tracing logic
SysfNoopTransaction adds an empty override for traceTransaction(Trace.Txndata trace) at lines 48-49, but this method is never meant to be called. The actual tracing logic is in CancunTxnDataOperation's traceTransaction(Trace.Txndata trace, long totalUserTransactionsInConflation) method which is called from CancunTxnData.commit(). This empty override serves no purpose and creates confusion about which method should be used for tracing.
Signed-off-by: Fabio Di Fabio <[email protected]>
This addresses an issue that seems to only occur for CANCUN blockchain
reference tests starting with
besuVersion = 25.11.0-RC1-linea2
where tests 627, 626, 625, 623, 612, 608, 605, 601, 578, 576, 575, 574
... among others would produce besu errors
OlivierBBB
force-pushed
the
beta-v4.0-rc13-branch
branch
from
f874b70 to
167c971
Compare
…hen needed Signed-off-by: F Bojarski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the tracer branch to use for future prod releases to follow up with
beta-v4.0-rc20(the branch name hasrc13in it as legacy from 1st prod release)HOW TO
If there is a hotfix or a Besu version update, here is how you can proceed to release
beta-v4.0-rcNbeta-v4.0-rc13-branch(check you have the latest commit)beta-v4.0-rc13-constraint-branch(check you have the latest commit)besuVersioningradle.propertiesbeta-v4.0-rc13-constraint-branchbranch with your new commit so it stays up-to-date on the reporeleaseVersioningradle.propertiestobeta-v4.0-rcNbeta-v4.0-rc13-branchso it stays up-to-date on the repoarith-devbranch : cherry-pick the commit of the fix from thebeta-v4.0-rc13-branch, open a new branch fromarith-dev, apply it and open a PR that you merge onarith-devbeta-v4.0-rcN, choose Target branchbeta-v4.0-rc13-branch, add release title asbeta-v4.0-rcN, edit notes to add the changes since previous release, publish as latestbeta-v4.0-rc13-branch, and check they are passingVERSION
beta-v4.0-rc1625.10.0-linea2VERSION
beta-v4.0-rc1425.10.0-linea1VERSION
beta-v4.0-rc13The tracer for
beta-v4.0-rc13is the same as forbeta-v4.0-rc12on top of which we've applied :beta-v4.0-rc11-TRACER-only-columns-hotfix)Note
Refactors opcode handling and bridge topic types, enriches TXN/RLP tracing, adds Prague execution-spec blockchain tests with supporting Gradle/templates/ignores, expands CI (build/unit/replay), and bumps Besu/release versions.
tracePreOpcodewith explicitcall*methods (Add/Bin/Mod/Shf/Ext/Wcp) invoked fromStackOnlySectionandExpSection; updateBlockhashto deferredcallBlockhash.AccountSnapshot.tracedHasCode; adjustTxSkipSectiongas used (gasLimit - gasRefunded).proverUserTxnNumberMaxand relative maxima; wire through Cancun modules.BytestoBytes32; propagate inHub/L1BlockSize.referenceExecutionSpecBlockchainTests; include JaCoCo report.releaseVersiontobeta-v4.0-rc23andbesuVersionto25.11.0-RC1-linea2.Written by Cursor Bugbot for commit d92ab9c. This will update automatically on new commits. Configure here.